Closed suujia closed 6 years ago
Oops this is really messy pull request. Let me try again
For future, you can in fact reuse the same pull request. This PR was based on your branch default
. You can force push a new branch also named default
to your repo, and this PR will be updated with the new contents of that branch. I can show you in person if you like.
See at the top of this PR where it says:
suujia wants to merge 28 commits into bcgsc:master from suujia:default
https://github.com/bcgsc/orca/commit/3c9d6bac62fa821870cee01d9fa95e5e1f6b3a7d https://github.com/bcgsc/orca/commit/1a606fa4373616e60d81912604e3171e4aed9a9d
Ok I see. I ended up squashing it and accidentally committing straight to it. :sweat_smile: noted for future, thank you.
Relevant previous commit: https://github.com/bcgsc/orca/pull/51 Asked ho to override default rules warning severity: https://github.com/projectatomic/dockerfile_lint/issues/110
Changes to be made specific to ORCA for the CI to pass. (Warnings for sudo does not exist as rule in default file Warnings for :latest should be set to info)