search

bcgsc / physlr

:chains: Construct a Physical Map from Linked Reads
GNU General Public License v3.0
18 stars 8 forks source link

Physlr map c++ #149

Closed jwcodee closed 2 years ago

jwcodee commented 4 years ago

physlr map takes a long time mostly because loading in a large dictionary in python takes a long time.

jwcodee commented 4 years ago
Time (hh:mm:ss) Ram (GB)
Python 16 threads split 1:00:36 179
C++ 16 threads split 0:10:45 58
Python 16 threads unsplit 1:41:28 216
C++ 16 threads unsplit 0:15:54 69
jwcodee commented 4 years ago

I figured you were using max like an indicator variable, so it would make sense that if the vector is empty, to return that indicator/NA-like variable. Just feels weird to check for an empty vector twice and add a random variable if it's empty instead of dealing with it in a function call? Fine to leave at it is though if you want -- I don't feel strongly.

As I mentioned, this approach has the least lines of code so I chose it.

github-actions[bot] commented 2 years ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your interest in Physlr!