lcoombe
commented
3 years ago Looks good to me Amirhossein! The generator expression fix looks fine to me - I find those really cool and useful in that sort of context!
Closed aafshinfard closed 3 years ago
lcoombe
commented
3 years ago Looks good to me Amirhossein! The generator expression fix looks fine to me - I find those really cool and useful in that sort of context!
Three pylint errors due to a pylint active unresolved bug: https://github.com/PyCQA/pylint/issues/3675 I fixed this by temporarily disabling the error codes for the lines
+ a warning and a recommendation at line 2435 (I am not sure I fixed it correctly, please double-check. It suggested that we use generators instead)