Add support for node 16 to build

bcgsc / pori_graphkb_client

Front-end web client for the GraphKB project

https://bcgsc.github.io/pori

GNU General Public License v3.0

9 stars 1 forks source link

Add support for node 16 to build #20

Closed creisle closed 2 years ago

creisle commented 2 years ago

[ ] Update the build workflow to use a matrix and test on node versions: 12, 14, and 16
[ ] Update the docker container to default to node 16
[ ] test running the node-16 docker container with the orientdb and graphkb client containers

creisle commented 2 years ago

@elewis2 It occurs to me that for the client we probably only need 1 version of node supported since we transpile the whole thing when it is actually used anyway so it is probably a waste of build minutes to have more than one. How do you feel about just fixing it to use node-16 and ditching 12/14?

areisle commented 2 years ago

I tried swapping to node16, but it seems there's dependencies with conflicting dependencies of react versions, the version of aggrid being used requires < react@17, and @testing-library/react-hooks requires >= react@17. so I think this will depend on first updating aggrid and react

areisle commented 2 years ago

at trying to upgrade react, ran into many other dependencies that need updating to get everything to resolve so that we can use node 16.

[ ] ag grid
[ ] react
[ ] enzyme (replace since already using both it and testing-library)
[ ] react-select (replace since also have mui lab and can just use that one)
[ ] babel-eslint. deprecated, replaced by @babel/eslint-parser which will need newer eslint, so all the eslint deps will need to be updated and new linting errors fixed.
[ ] webpack and friends