search

bcgsc / pori_python

GNU General Public License v3.0
0 stars 1 forks source link

improve async upload check; add test #14

Closed elewis2 closed 3 months ago

elewis2 commented 3 months ago

Updates reports-async usage to match new return values and adds upload tests.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (e04377e) to head (aabd8bb).

Files Patch % Lines
pori_python/ipr/connection.py 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14 +/- ## =========================================== - Coverage 86.19% 85.79% -0.40% =========================================== Files 19 19 Lines 2158 2168 +10 =========================================== Hits 1860 1860 - Misses 298 308 +10 ``` | [Flag](https://app.codecov.io/gh/bcgsc/pori_python/pull/14/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bcgsc/pori_python/pull/14/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | `85.79% <0.00%> (-0.40%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.