search

bcgsc / pori_python

GNU General Public License v3.0
0 stars 1 forks source link

Bugfix/devsu 2477 filter gkb matches #37

Closed mathieulemieux closed 2 weeks ago

mathieulemieux commented 4 weeks ago

See https://www.bcgsc.ca/jira/browse/DEVSU-2477

mathieulemieux commented 4 weeks ago

Here are some before/after filtering counts:

/projects/POG/POG_data_hg38_no_alt/POG1858/gsc_report/gsc_report-13.0.0/genomic/F145899_F145808_F145970/ipr_report.json
before: 144
after: 115
/projects/POG/POG_data_hg38_no_alt/POG1868/gsc_report/gsc_report-13.0.0/genomic/F146248_F145962_F146348/ipr_report.json
before: 597
after: 569
/projects/POG/POG_data_hg38_no_alt/POG1911/gsc_report/gsc_report-13.0.0/genomic/F147930_F147420_F148116/ipr_report.json
before: 222
after: 205
codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.15%. Comparing base (e4689df) to head (2832eb5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #37 +/- ## =========================================== + Coverage 86.04% 86.15% +0.10% =========================================== Files 18 18 Lines 2179 2196 +17 =========================================== + Hits 1875 1892 +17 Misses 304 304 ``` | [Flag](https://app.codecov.io/gh/bcgsc/pori_python/pull/37/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bcgsc/pori_python/pull/37/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | `86.15% <100.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mathieulemieux commented 2 weeks ago

I'll post comparisons for wildtypes tomorrow

mathieulemieux commented 2 weeks ago

/projects/POG/POG_data_hg38_no_alt/POG1868/gsc_report/gsc_report-13.0.0/genomic/F146248_F145962_F146348/ipr_report.json

before:

after:

2 unique statements affected:

mathieulemieux commented 2 weeks ago

When pori_python & ipr_api dev get fixed, I'll be able to generate comparative genomic reports.