search

bchanudet / OctoPrint-Octorant

Discord plugin for OctoPrint
MIT License
26 stars 14 forks source link

Multiple discord channels #45

Closed Ionys320 closed 4 years ago

Ionys320 commented 4 years ago

Add the possibilities to have multiple discord channels and not only one.

Ionys320 commented 4 years ago

Maybe it's not fully okay, but I cant test because I dont have a 3D printer.

bchanudet commented 4 years ago

Hello,

Thanks for the PR, however, that's an awful lot of commits to review, and seeing that @cameroncros is mentioned in the commit list, I have the impression this Pull Request was more destined to be sent to cameroncros/OctoPrint-DiscordRemote ?

Also, even without a 3D Printer, Octoprint and the plugin can be tested by using the Virtual Printer : https://docs.octoprint.org/en/master/development/virtual_printer.html

cameroncros commented 4 years ago

This was definitely for me I think.

bchanudet commented 4 years ago

Thanks for your feedback :)

I've seen you re-created the PR in DiscordRemote, so I'll close this one.