search

bchavez / Bogus

:card_index: A simple fake data generator for C#, F#, and VB.NET. Based on and ported from the famed faker.js.
Other
8.81k stars 500 forks source link

Initialize Randomizer with Random #351

Closed howardwang0620 closed 3 years ago

howardwang0620 commented 3 years ago

Allows Randomizer's global random Seed to stay consistent with usages of randoms in outer scopes.

bchavez commented 3 years ago

@howardwang0620 can you please allow edits to this PR?

howardwang0620 commented 3 years ago

@howardwang0620 can you please allow edits to this PR?

Not sure where I can do that, don't see the "Allow edits from maintainers" option. Can you see the contents of the PR?

bchavez commented 3 years ago

Hi @howardwang0620, I can see the contents of the PR; however,

I tried making the edits, but GitHub denied it. I suspect it might be because the PR looks like it originates from an organizational account, not howardwang0620; but not totally sure.

This probably won't get merged as-is, especially without an accompanying unit test. If you want to write one, please see the GitHub folder in the test project, and please adhere to all coding conventions.

howardwang0620 commented 3 years ago

This probably won't get merged as-is, especially without an accompanying unit test. If you want to write one, please see the GitHub folder in the test project, and please adhere to all coding conventions.

Gotcha, closing and will make a new PR for this change