Open flimtix opened 2 years ago
In addition, the service lorempixel is no longer available / does not respond.
I think we'll need to remove the LoremPixel service in our next major update. Thank you for reporting.
I will take this, will raise PR soon
@prasadtelkikar Have you found time to create the pull request to remove lorempixel.com from the codebase? @bchavez I would like to contribute by removing lorempixel.com from the codebase altogether. Would this be appreciated?
Hi @marijnz0r, yes I think removing LoremPixel.com is okay. I think the URLs and site have been broken for a long time.
Just a few more points:
Thanks a bunch for your help.
Version Information
What is the expected behavior?
Expected is that Bogus will create a link based on the picsum.photos documentation.
What is the actual behavior?
A link is created with
?image=id
, which is outdated. It is possible that this request will not be possible anymore at some point.Any possible solutions?
Specify the
Id
via the ULR and not as a parameter:How do you reproduce the issue?
Create a picsum link via Bogus.
Can you identify the location in Bogus' source code where the problem exists?
DataSet/Images.cs
If the bug is confirmed, would you be willing to submit a PR?
No, because my recommended solution can already be found here in this report. Thus, this only needs to be added / overwritten.