bchavez / Bogus

:card_index: A simple fake data generator for C#, F#, and VB.NET. Based on and ported from the famed faker.js.
Other
8.62k stars 491 forks source link

License expression in nuget package not set #451

Closed garcipat closed 4 months ago

garcipat commented 1 year ago

Version Information

Software Version(s)
Bogus NuGet Package until Current (34.0.2)
.NET Core? 6
Windows OS? 10
Visual Studio? 2022

What is the expected behavior?

License information is filled in the nuget package

What is the actual behavior?

Only the License Url is filled and points to the MIT license

Any possible solutions?

Just fill the License expression field in the nuget spec.

How do you reproduce the issue?

Get the nuget and inspect the spec file. Also When adding the nuge tpackage

Can you identify the location in Bogus' source code where the problem exists?

the .csproj file

If the bug is confirmed, would you be willing to submit a PR?

I'm willing but never did that before.

bchavez commented 1 year ago

Hi. Could you help me understand why this is a problem?

garcipat commented 1 year ago

Hi

We are tracking the Licenses of our used packages and are collecting that information from the package. But if there is just a link to the license, we cannot identify the license type programatically. Just if you open it manually. It would be bice if this would be included. Of course only if it wasn't left out intentionally.

Kind regards

Brian Chavez @.***> schrieb am Fr., 18. Nov. 2022, 01:36:

Hi. Could you help me understand why this is a problem?

— Reply to this email directly, view it on GitHub https://github.com/bchavez/Bogus/issues/451#issuecomment-1319398160, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXTN42A4DOPASPGZJK6NCTWI3FRDANCNFSM6AAAAAASDQRBJM . You are receiving this because you authored the thread.Message ID: @.***>

bchavez commented 4 months ago

Going through the issues list and cleaning up. Gonna mark this as a duplicate of #499 . Please subscribe to issue #499 for updates.