search

bchavez / Bogus

:card_index: A simple fake data generator for C#, F#, and VB.NET. Based on and ported from the famed faker.js.
Other
8.73k stars 496 forks source link

Update `zh_CN` dataset to latest #548

Open EminemJK opened 4 months ago

EminemJK commented 4 months ago

Bogus NuGet Package

35.5.1

.NET Version

.Net6

Visual Studio Version

17.8

What operating system are you using?

Windows

What locale are you using with Bogus?

zh_CN

What's the problem?

For the first time, I find this is a very good code base, but unfortunately it lacks most Chinese data, I am happy to provide data for it, please tell me how to supplement the data resources.

Provide LINQPad Example

.

What other possible solutions or alternatives have you considered?

.

digitalcoyote commented 4 months ago

@EminemJK since Bogus gets most of its data from faker.js, if you're willing to contribute upstream instead, it would help more projects to get Chinese data.

bchavez commented 4 months ago

Thank you for your interest in supporting the project. Yes as @digitalcoyote mentioned, the best approach is to contribute upstream to faker.js for locale data.

https://github.com/faker-js/faker

Once you've done that, you can add a GH issue here to request and track the zh_CN update.

Eventually Bogus will pull locale updates from faker.js. Pulling locale updates from faker.js is my next block of work on the roadmap but this process takes a while because I have to be really careful dealing with breaking changes and understanding well any unit tests that might break.

EminemJK commented 4 months ago

Sure, I'll take a look at faker.js. As a developer from China, I've also noticed some Chinese syntax issues in the Bogus library, such as with names. In Chinese, the naming convention is to put the surname before the given name, which is the opposite of English names.