[BugTrapServer] Email SSL support

bchavez / BugTrap

:beetle: BugTrap: Catch unhandled exceptions in unmanaged and managed .NET code.

MIT License

166 stars 80 forks source link

Closed GoldRenard closed 8 years ago

GoldRenard commented 8 years ago

I'm surprised that BugTrapServer e-mail reporting doesn't support SSL/TLS.

bchavez commented 8 years ago

Very nice! Again, excellent work m8! LGTM. You should be able to merge once CI goes green.

Ops, build results just came in. Seems like this line here:

_RequestHandler.aspx.cs_

smtpClient.EnableSsl = this.applicationSettings.SmtpSSL;

appSettings is passed in as an argument so (this) reference isn't needed. :+1:

GoldRenard commented 8 years ago

Yeah, my mistake. I don't have ASP.NET support on my VS installation so I've just copy-pasted this feature to webapp. Should be fixed now.