Adding Notification Event, fixing transaction bug and adding Superficial DI

[granthoff1107]

Note: the wallet:addresses:new-payment description has been modified to more accurately reflect the behavior of the api.

The original description is: New payment has been made to a Bitcoin address Our Description is: New payment has been made to a Bitcoin address

The the api documentation is misleading because it implies only bitcoin addresses work. While I've been testing using Ethereum and these work as well.

[bchavez]

Fantastic work. Thanks Grant. I'll publish a new release a new version shortly.

[bchavez]

Hey Grant,

Changes are now live: https://www.nuget.org/packages/Coinbase/5.0.3

Thanks again, Brian

:walking: :sunglasses: "So don't delay... act now supplies are running out..."

[granthoff1107]

Thanks I’m still sorting out a few thing with notifications. I may have another pull request in a few days.

I’ve been trying to get Coinbase to answer some of my questions but there not so timely,

Just as a heads up, minor detail but I think the user agent is still posting as version 2, I saw it in my request bin when testing notifications

On Sat, Dec 1, 2018 at 9:48 PM Brian Chavez notifications@github.com wrote:

Hey Grant,

Changes are now live: https://www.nuget.org/packages/Coinbase/5.0.3

Thanks again, Brian

🚶 😎 "So don't delay... act now supplies are running out..." https://www.youtube.com/watch?v=LQj--Kjn0z8

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bchavez/Coinbase/pull/47#issuecomment-443476328, or mute the thread https://github.com/notifications/unsubscribe-auth/AMsMnevhgsvY0vWddOy9iGVPcpX9i6gUks5u0z92gaJpZM4Y9MZ5 .

[bchavez]

Hm. Authenticated requests should contain the User-Agent header value as shown in the screenshot below, but it does seem Data requests don't. I'll get that fixed.

Perhaps the v2 you were seeing was in the query string?

[granthoff1107]

When I get back to my computer I’ll pull down what I was seeing on request bin

On Sat, Dec 1, 2018 at 11:44 PM Brian Chavez notifications@github.com wrote:

Hm. Authenticated requests should contain the User-Agent header value as shown in the screenshot below, but it does seem Data requests don't. I'll get that fixed.

Perhaps the v2 you were seeing was in the query string?

[image: fiddler_2410] https://user-images.githubusercontent.com/478118/49335799-b0d7a200-f5a9-11e8-911a-48344ddb5d53.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bchavez/Coinbase/pull/47#issuecomment-443481178, or mute the thread https://github.com/notifications/unsubscribe-auth/AMsMnRBWiOs5EocWQcgjmINvQVA27TnGks5u01qmgaJpZM4Y9MZ5 .