search

bchavez / Coinbase

:moneybag: A .NET/C# implementation of the Coinbase API.
https://developers.coinbase.com/api/v2
MIT License
170 stars 92 forks source link

Update Objects.cs #53

Closed bheesbeen closed 5 years ago

bheesbeen commented 5 years ago

Also the CreatedAt and UpdatedAt properties form Buy nullable

bchavez commented 5 years ago

Hi @bheesbeen,

Thank you for the PR. Do you have the JSON response where these fields are nullable? (or maybe a stack trace showing the issue?) I'd like to write some unit tests for these issues.

Thanks, Brian

bheesbeen commented 5 years ago

Brian,I am sorry, i just got the json exception pointing me to the created_at propery.I did not capture any json.Bert

bchavez commented 5 years ago

Hi Bert,

I've marked all .CreatedAt and .UpdatedAt fields as nullable in the object models. Hopefully that resolves these kinds of issues once and for all (related #52).

You can get the new Coinbase v5.0.8 bits here: https://www.nuget.org/packages/Coinbase/5.0.8

Thanks again for your help! Brian

:walking: :sunglasses: "So don't delay... act now supplies are running out..."

bheesbeen commented 5 years ago

Thanks!