search

bchavez / RethinkDb.Driver

:headphones: A NoSQL C#/.NET RethinkDB database driver with 100% ReQL API coverage.
http://rethinkdb.com/api/java
Other
384 stars 134 forks source link

Fixes #113, allow client-side generation of ReGrid file ids. #114

Closed bchavez closed 7 years ago

bchavez commented 7 years ago

Fixes #113, allow client-side generation of ReGrid file ids.

cc @oliverjanik

:evergreen_tree: :crystal_ball: PINES - Fate

oliverjanik commented 7 years ago

LGTM. thanks.

oliverjanik commented 7 years ago

It just occurred to me, but Guid is a struct, will the driver handle default(Guid) correctly if the ForceFileId is not set?

oliverjanik commented 7 years ago

Looks like it works well. Empty Guid is treated as non-existent Id.

bchavez commented 7 years ago

It should. See the default handling rule here:

https://github.com/bchavez/RethinkDb.Driver/blob/ef07560225e9aa2d363e67830430e83ac2a60a39/Source/RethinkDb.Driver.ReGrid/FileInfo.cs#L29

:sunglasses:

:last_quarter_moon: :last_quarter_moon: "Uh huh, you know what it is. Black and yellow..."