Closed roald-di closed 6 years ago
bchavez
commented
6 years ago Hey @roald-di
You have done a really great job @roald-di ! It's fantastic and looks beautiful. It's perfect.
Thank you for putting the time and effort in resolving your issue in the LINQ provider. I'll tag a new release with your changes soon CI is done. :+1:
Again, thank you for your contribution. It always makes me really happy to see such high-quality PRs like this.
:car: :blue_car: "Let the good times roll..."
roald-di
commented
6 years ago Wow that was fast!
You're really doing an excellent job in managing this project. 👍 It has been a pleasure to contribute.
bchavez
commented
6 years ago Thank you for the kind words @roald-di :)
BTW, your changes are now live! See: RethinkDb.Driver.Linq v2.3.22. Enjoy!
And being quick to resolve your issue with a new release is the least I can do! :sunglasses:
-Brian
:boom: :fire: "Set it ablaze like a candle wick... Light it up, light it up..."
Issue: https://github.com/bchavez/RethinkDb.Driver/issues/125
There were some more places that used the property in the query besides the one mentioned in the issue so I updated those as well. The tests don't cover every single operator but they do exercise all the code paths that contain my changes.
I followed your advice (thank you!) pretty closely, the only difference is the signature of
GetJsonMemberNamewhich takes aMemberInfoas an argument. I think this should make it easier to extend if necessary i.e. if it becomes necessary to read attributes from the property, however I can change that if you prefer.