bchavez / RethinkDb.Driver

:headphones: A NoSQL C#/.NET RethinkDB database driver with 100% ReQL API coverage.
http://rethinkdb.com/api/java
Other
383 stars 134 forks source link

Retrieve Raw Json Result From Server #141

Closed aliprogrammer69 closed 5 years ago

aliprogrammer69 commented 5 years ago

RunAsRawJson and RunAsRawJsonAsync are developed to ReqlAst class to retrieve server data result as raw json string

bchavez commented 5 years ago

Hi Ali,

I appreciate the enthusiasm and the work you've put into the PR. However, I've pushed 1dd5e3d which supersedes this PR.

The new .RunUnsafeAsync method should now be available in v2.3.100 available here: https://www.nuget.org/packages/RethinkDb.Driver/2.3.100

The .RunUnsafeAsync returns the raw Response protocol object that you can use for Response.Data.ToString().

This method will remain an undocumented feature because it completely bypasses client-side response processing mechanisms inside the driver which can lead to memory leaks if used improperly. As per the XML docs:

/// <summary>
/// Runs a query on the server and returns the raw Response object in an unsafe way
/// with minimal client-side processing. The unbridled use of this method can
/// lead to memory leaks on both the client and server. This method should only
/// be used in well-understood and advanced scenarios.
/// </summary>

Also, as a future pro-tip (and unspoken GitHub etiquette), please try to avoid changing white-space and avoid changing coding styles in the source code that aren't related to the topic at hand. Keeping code changes focused and on topic helps the code-review process go smoother. For example, +71 additions and -9 deletions is much easier to review than +469 additions and −455 deletions.

Hope that helps.

Thanks, Brian

:walking: :sunglasses: "So don't delay... act now supplies are running out..."

aliprogrammer69 commented 5 years ago

Thanks a lot. Ali