Closed jrote1 closed 3 years ago
Hi Jake, thanks for the PR! Happy to see you again!
I'm currently on vacation traveling. I briefly looked at the PR and it looks okay! I don't have access to my dev box to test, but if the build server says it's okay we're good!
I think you still have commit access so feel free to merge if you feel it's ready for release! Ping me if you'd like me to issue a release on NuGet after merging!
Again, great to see you again Jake! Hope all is well!
Thanks, Brian
@bchavez I'm working on a bunch of additions to the Linq provider so maybe I'll pull this into a Linq improvements branch and then we can pull into master when your back from vacation. What do you think? Hope your having a great vacation and is good to be back
Hey Jake! Whichever approach you want to take is totally fine with me! I should be back around Oct 4th.
I think the only requirement we should keep is making sure master
is always production-ready. Being able to cut a release from master
at any time is super powerful for quick iteration times and emergency bug fixes! 👍
Before submitting your PR, please review the following checklist:
I haven't written C# for over 2 years so be kind :p I'm joking be nice a thorough. It's good to contribute again