search

bcherny / json-schema-to-typescript

Compile JSON Schema to TypeScript type declarations
https://bcherny.github.io/json-schema-to-typescript-browser/
MIT License
2.95k stars 392 forks source link

fix build #621

Closed benmccann closed 3 months ago

benmccann commented 3 months ago

npm run build is currently failing. This fixes it

bcherny commented 3 months ago

How are you running the build? It seems to work fine https://github.com/bcherny/json-schema-to-typescript/actions/runs/10434515274

benmccann commented 3 months ago

I just ran npm run build from the CLI locally. It gives me:

> browserify src/index.ts -s jstt -p tsify > dist/bundle.js

node_modules/parse-json/index.js:33
        throw jsonErr;
        ^
ErrorEXError [JSONError]: Trailing comma in array at 8:5 in tsconfig.json
    ],
    ^
    ],
    ^
bcherny commented 3 months ago

Ah, you're right! We don't run the client build in CI, so CI works fine. Thanks for the fix.