Open benmccann opened 3 weeks ago
it is worth noting that choosing your dependencies purely based on number of downloads isn't the best idea (re the closed PR)
fdir is much faster than existing glob libraries, even when combined with picomatch (to provide glob functionality). tinyglobby does not have as many downloads but is built on top of fdir, which is a well established library.
this repo would benefit from the performance improvement, and from reduction in install size
splitting the package seems like a larger effort that should be discussed/worked on at some other later point
glob
is responsible for 26 out of 37 dependencies for this library: https://npmgraph.js.org/?q=json-schema-to-typescript. I'd love to see if we can find a way to reduce that.A few options I can think of:
fdir
(1M downloads / wk) andpicomatch
(50m downloads / wk)tinyglobby
in https://github.com/bcherny/json-schema-to-typescript/pull/622. See that PR for the full background and additional details regarding this issuejson-schema-to-typescript
and re-export the stuff contained in core, so that users could continue to install just the one package they need and the change could be made in a backwards-compatible fashion. This would also remove other packages likeminimist
andis-glob
from the core dependencies as well