search

bcherny / tslint-no-circular-imports

TSLint plugin to detect and warn about circular imports
MIT License
86 stars 12 forks source link

Added search-depth-limit parameter #23

Closed JoshuaKGoldberg closed 6 years ago

JoshuaKGoldberg commented 6 years ago

Limits the depth of cycle reporting to a fixed to a fixied size limit for a list of files. This helps improve performance, as most cycles do not surpass a few related files.

As I mentioned in the issue, we could theoretically fix the crashes by switching to an iterative solution. This is still a desirable change IMO because erroring files will do so faster.

Fixes #18 (recreation of #20 but with a good git history)

JoshuaKGoldberg commented 6 years ago

Ping @bcherny - is there anything else that should be done on my end?

bcherny commented 6 years ago

Looks good, sorry about the delay. Published 0.6.0.

JoshuaKGoldberg commented 6 years ago

Awesome, thanks!