search

bcherny / tslint-no-circular-imports

TSLint plugin to detect and warn about circular imports
MIT License
86 stars 12 forks source link

Fix Tests involving subdirectory import case #29

Open chigix opened 5 years ago

chigix commented 5 years ago

Referenced to : https://github.com/bcherny/tslint-no-circular-imports/issues/28

chigix commented 5 years ago

About the failed build, I find there is exactly difference on running test between windows and ubuntu platform. I've also confirmed same error in building on my ubuntu machine, which is interesting. I'll check and update this fix later today.

chigix commented 5 years ago

@bcherny I've fixed all problems and request a review.

bcherny commented 5 years ago

Hey there @chigix, thanks for the contribution. Once you have a chance to fix the TypeError (see CircleCI output), I'll be happy to merge this.

https://circleci.com/gh/bcherny/tslint-no-circular-imports/43

chigix commented 5 years ago

@bcherny I see. I'll push new fix commit this week.

chigix commented 5 years ago

@bcherny I have pushed a new fix pull request. Expecting to have a review.