bcherny / tslint-no-circular-imports

TSLint plugin to detect and warn about circular imports
MIT License
86 stars 12 forks source link

Moved tslint and typescript to peer dependencies #8

Closed andyrooger closed 6 years ago

andyrooger commented 6 years ago

As far as I can tell these dependencies should come from the project using the plugin at runtime. I've moved TS and tslint, as they are, into dev dependencies for tests etc, and added more lenient peer dependencies for them when installed into other projects.

I'm not fixing a particular bug here, but it seemed like a reasonable thing to do after I changed the node typings.

bcherny commented 6 years ago

Looks good!