search

bcherny / undux

⚡️ Dead simple state for React. Now with Hooks support.
https://undux.org
MIT License
1.49k stars 31 forks source link

Make undux React 18 compatible #160

Open kassens opened 11 months ago

kassens commented 11 months ago

Subscriptions that are torn down in componentDidUnmount need to be re-established in componentDidMount as both functions can be called multiple times in concurrent mode.

I was not sure how critical the GC related comments are. I don't know if that behavior can be kept when we need to re-establish the subscriptions.

bcherny commented 9 months ago

I've just updated all the dependencies to latest. Mind rebasing? Then tests should pass.