bchiang7 / v4

Fourth iteration of my personal website built with Gatsby
https://v4.brittanychiang.com/
MIT License
7.6k stars 3.78k forks source link

BUG FIXED: Project card when only one link(github) #287

Open parthdasawant opened 1 year ago

parthdasawant commented 1 year ago

There was a BUG; now FIXED.

Scenario: When there is only one link e.g. GitHub(other than an external link), if one clicks the project card, one will get redirected to the original site in a new tab.

ss

here to the Localhost:9002

Solution: Add || github just after external in href in the line no. 245 at src/components/sections/projects.js

sol
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4 ❌ Failed (Inspect) Oct 11, 2023 7:05pm
netlify[bot] commented 1 year ago

Deploy Preview for brittanychiang-v4 ready!

Name Link
Latest commit 3b8611f43ac9c5a120e0a56774c054e9ca3ccfc5
Latest deploy log https://app.netlify.com/sites/brittanychiang-v4/deploys/6526f1e3e9c3cf0008f74a5f
Deploy Preview https://deploy-preview-287--brittanychiang-v4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.