search

bchinfo / bch.info

Bitcoin Cash informational website
https://bch.info
MIT License
34 stars 43 forks source link

Added KeepKey to list of hardware wallets. Update wallets.html. #173

Closed greatwolf closed 1 year ago

greatwolf commented 1 year ago

Added KeepKey under hardware wallet since it has bch support. Addresses issue #61.

greatwolf commented 1 year ago

Would anyone mind taking a look at my PR?

netlify[bot] commented 1 year ago

Deploy Preview for bch ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/bch/deploys/638c1a83113ea731f2b5df64
Deploy Preview https://deploy-preview-173--bch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

merc1er commented 1 year ago

Would anyone mind taking a look at my PR?

I still think this shouldn't be merged until the official client comes out of beta.

@imaginaryusername what do you think?

imaginaryusername commented 1 year ago

Not sure what's the relationship between their different clients, but found this on the website:

image

so the current "official way to access" seems to be entirely web-based at https://app.shapeshift.com

someone known with a keepkey needs to test this and report if it works with BCH.

greatwolf commented 1 year ago

I still think this shouldn't be merged until the official client comes out of beta.

@imaginaryusername what do you think?

Which client are you referring to? If you're talking about app.shapeshift.com, it already has bch support enabled and operational.

greatwolf commented 1 year ago

I'll share a couple screenshots here to show that it's working, at least the basic sending and receiving part of it is fine.

image image image

When I get a chance I'll also test Electron Cash with my KeepKey and will report back. If it's anything like the regular electrum or Dash's fork of electrum then it should work fine.

greatwolf commented 1 year ago

Okay I just tested my KeepKey on Electron-Cash-4.2.12, current latest at time of this posting. This was tested using firmware v7.5.0 and bootloader v2.1.4 btw. It's able to communicate with and verify the pin as well as passphrase on my KeepKey. I'm able to send and receive fine using addresses generated from the device. All the transaction history shows up as well.

From what I can tell, everything works as it should.

melroy89 commented 1 year ago

Not sure what's the relationship between their different clients, but found this on the website:

image

so the current "official way to access" seems to be entirely web-based at https://app.shapeshift.com

someone known with a keepkey needs to test this and report if it works with BCH.

Yea they do support BCH. But why is it using a DEX online instead of an offline open source app?

greatwolf commented 1 year ago

Yea they do support BCH. But why is it using a DEX online instead of an offline open source app?

yeah, it's not ideal. The quick backstory is before Shapeshift acquired KeepKey the main way to access it was through the Chrome Extension. After the acquisition they basically wanted to migrate users onto their shapeshift platform. Unfortunately not all the features were made available, like for example bitcoin gold, digibyte and some other altcoin support.

I needed a way to access those too and since it's clearly not a firmware support issue, it was a UI interface issue, I just took the original Chrome Extension source as the starting base and started improving and maintaining it myself.

That all said, there is work being done in the shapeshift community since turning into a DEX/DAO setup, specifically highlander is working on a standalone webapp client. It's still in it's early stages you can find it here: https://github.com/keepkey/keepkey-desktop. That gets you closer to an open-source standalone app you can use. Feel free to hop on their shapeshift discord: https://shapeshift.com/join

I haven't tested that though, I've only confirmed app.shapeshift.com works, ElectronCash works and the KKClient fork I've been maintaining works.

SayoshiNakamario commented 1 year ago

Have used a Keepkey with Electron Cash without issue for years. Not that I'm an anybody :)

imaginaryusername commented 1 year ago

@SayoshiNakamario I think you definitely qualify as "known community member" tbh, can you give the shapeshift webapp a quick try? :)

SayoshiNakamario commented 1 year ago

Verified sending/receiving with Keepkey on shapeshift's webapp works for BCH, but only on Chrome (Version 107.0.5304.123), Firefox (107.0.1) would not detect the Keepkey. I Shapeshift has only ever officially supported Chrome though.

imaginaryusername commented 1 year ago

Thank you. @merc1er I think it's safe to recommend a merge.

greatwolf commented 1 year ago

Verified sending/receiving with Keepkey on shapeshift's webapp works for BCH, but only on Chrome (Version 107.0.5304.123), Firefox (107.0.1) would not detect the Keepkey. I Shapeshift has only ever officially supported Chrome though.

yeah, I think any Chromium-based browser should work. I think the issue stems from firefox not supporting the webusb api interface. Without that any site or webapp won't be able to communicate with KeepKey or any other custom usb device for that matter.

melroy89 commented 1 year ago

@SayoshiNakamario I think you definitely qualify as "known community member" tbh, can you give the shapeshift webapp a quick try? :)

He is? His account seems almost not used in GitHub and pretty new actually.

imaginaryusername commented 1 year ago

@SayoshiNakamario I think you definitely qualify as "known community member" tbh, can you give the shapeshift webapp a quick try? :)

He is? His account seems almost not used in GitHub and pretty new actually.

He's the builder of helpme.cash

melroy89 commented 1 year ago

He is? His account seems almost not used in GitHub and pretty new actually.

He's the builder of helpme.cash

Ah I see. Thanks, you helped me.