bchinfo / bch.info

Bitcoin Cash informational website
https://bch.info
MIT License
34 stars 43 forks source link

WIP: Add signup.cash to js dev tools #42

Open p0o opened 3 years ago

netlify[bot] commented 3 years ago

Deploy preview for bch ready!

Built with commit 892cf925f4b617355af797dfec3acc1fbce0ef73

https://deploy-preview-42--bch.netlify.app

merc1er commented 3 years ago

The code in the PR looks good, but I haven't tried the package. It doesn't say what the package is for in the docs.

EDIT: it does explain in the following sections :)

@imaginaryusername what do you think about adding this tool?

merc1er commented 3 years ago

I just tested wallet.signup.cash and it is not sending transactions. It seems to be powered by this tool, so I would recommend waiting for a more stable release before listing it.

p0o commented 3 years ago

@merc1er May you try the example app for payment and let me know if it works? Thanks

https://signup-examples-v1.vercel.app/example_simple_tipping_button.html

merc1er commented 3 years ago

@merc1er May you try the example app for payment and let me know if it works? Thanks

https://signup-examples-v1.vercel.app/example_simple_tipping_button.html

What is the expected behaviour? It seems to be working on my end:

Screenshot 2020-10-26 at 15 29 37

p0o commented 3 years ago

It's a tipping button so you should be able to do a transaction and see the txid link Screen Shot 2020-10-26 at 4 33 02 PM

p0o commented 3 years ago

@merc1er The issue with the wallet should be fixed now. Would appreciate if you try again.

merc1er commented 3 years ago

It seems to be working now, but once in a while i get this:

Screenshot 2020-10-26 at 22 53 44

Actually it redirects me to this URL: https://wallet.signup.cash/send which returns a 404

p0o commented 3 years ago

@merc1er I think you were reloading the page on different paths. But good catch, forgot to redirect 404 to index. Already fixed.

netlify[bot] commented 3 years ago

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user