bcholmes / StarTrek2d20

Character creation tool for Star Trek Adventures RPG from Modiphius.
ISC License
18 stars 7 forks source link

Support Cyrillic Characters in PDFs #195

Closed bcholmes closed 4 months ago

bcholmes commented 4 months ago

The base PDF specification uses a version of the Helvetica font which does not really support Cyrillic characters (it has other langauge limitations as well). When you try to export the a character as a PDF, the export fails because the PDF cannot be properly saved.

The PDF library that the app uses (Hopding/pdf-lib) has some functions relating to changing the font, but to date, I've note been able to successfully export a PDF with Cyrillic characters in it.

Here are some relevant links:

bcholmes commented 4 months ago

PR #196 seems like a fix for this bug.

LoranRendel commented 4 months ago

PR #196 seems like a fix for this bug.

It's now a partial fix for Russian TNG only, we can replace font for every card type to get Cyrillic support in each sheet type.