bcholmes / StarTrek2d20

Character creation tool for Star Trek Adventures RPG from Modiphius.
ISC License
18 stars 7 forks source link

Typing in Year of Service wipes spaceframe #59

Closed Felderburg closed 1 year ago

Felderburg commented 2 years ago

I discovered that after a spaceframe, custom or otherwise, is added, if I type a new Year of Service, the custom frame gets wiped clean. This does not occur if I use the arrow selector to move the Year in Service up.

I suspect that this may be because spaceframes get wiped when the Year in Service is less than the year a class is introduced, and typing in 2300 e.g. makes the tool think the Year in Service is 2, then 23, then 230... so all spaceframes are wiped the instant a person starts typing.

I also suspect that this may not be fixable. Given that spaceframe is the only thing wiped (as far as I saw) it may not be important to fix.

Felderburg commented 1 year ago

So now the spaceframe isn't removed as typing happen, but it is removed if you click or tab outside the 'year in service' box once a year is typed. Additionally, if the year in service is too early, certain spaceframes don't appear on the list. I think this is all working as intended.

However, it might be a problem if someone decides the default 'year in service' is too late, tries to enter something earlier than a ship can exist, and gets annoyed/confused as to why the spaceframe is now gone. I would suggest adding year of service dates (beginning and end, given the 'ignore end of service checkbox) to the description, or perhaps the spaceframe selection table, so as to avoid potential confusion.