search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

No more dual version in package.json and --tag option #11

Closed royaltm closed 8 years ago

royaltm commented 8 years ago

Based on #10

First of all it's _backward incompatible_ due to use of "host" + "remote_path" instead of sole "host". People will have to change this one thing in their package.json (but only _once_ versus _always maintaining second version tag_).

The idea behind this patch is to facilitate "remote_path" property understood by node-pre-gyp which supports variable substitution. But then the node-pre-gyp will package under the "{stage_dir}/{remote_path}" so I had to modify file search path in uploadAssets.

I also added the custom --tag option along with the readme update.

Additionally I've ensured that the only access for the token you need is public_repo and repo_deployment.

royaltm commented 8 years ago

after 38cfe81 it's not breaking anymore, will find deeply all files in stage_dir/**

royaltm commented 8 years ago

I'll be back ;)