search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

exit with a non 0 exit code on publish error #13

Closed reconbot closed 8 years ago

reconbot commented 8 years ago

Right now we only console.error but it would make it easier to detect failures on my ci if exited with a non zero exit code.

bchr02 commented 8 years ago

Okay, I'll add a process.exit(1); if an error occurs anywhere in the process instead of just within init().

bchr02 commented 8 years ago

fixed with https://github.com/bchr02/node-pre-gyp-github/issues/14

Thanks for bringing this to my attention.

bchr02 commented 8 years ago

@reconbot have you had a chance to try it out now with the changes I made? Also, so you know, I recently added unit tests and have 100% test coverage.

reconbot commented 8 years ago

This actually saved me from a different issue, Travis started giving me machines with the wrong architecture and I only need noticed because the upload started failing.

So A+ I'm quite happy about this.

On Fri, Jun 3, 2016, 8:05 AM Bill Christo notifications@github.com wrote:

@reconbot https://github.com/reconbot have you had a chance to try it out now with the changes I made? Also, so you know, I recently added unit tests and have 100% test coverage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bchr02/node-pre-gyp-github/issues/13#issuecomment-223561690, or mute the thread https://github.com/notifications/unsubscribe/AABlbmmAMnm-CYYaRyE0dG1FSOC5zjy0ks5qIBhxgaJpZM4ImIE7 .

bchr02 commented 8 years ago

that's awesome. thanks for confirming.