search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

Update module node-github to 12.1.0 #22

Closed cosminghitea closed 6 years ago

cosminghitea commented 6 years ago

Hello, I update this tool to use the node-github module 12.1.0 also I add a flag for the proxy. I test the tool manually but I didn't test the test you made.

bchr02 commented 6 years ago

@cosminghitea Thank you for this PR!

To run the tests, install the dev dependencies and then run npm test

I ran the tests and they are all failing. I believe this has to do because of the updated node-github. Therefore the mocks within test.js need to be updated. Can you make these changes and then add additional tests so that we can keep 100% coverage? Thank you!

cosminghitea commented 6 years ago

Sure I will take a look on that.

cosminghitea commented 6 years ago

Ok I repair the tests should work now

ptusch commented 6 years ago

I'd love to have this as well. 👍

nox-do commented 6 years ago

Cool. Didn't know this exists

bchr02 commented 6 years ago

node-github was deprecated