Support Github Enterprise, upgrade Github client package

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.

MIT License

52 stars 32 forks source link

Closed allenluce closed 6 years ago

allenluce commented 6 years ago

@octokit/rest is the new (since January) NPM package for accessing the Github API. There are some differences that are taken care of here.

One of them is setting the mime type on asset upload.

Since octokit initialization happens on init (instead of module execution), I've hacked up a means using Sinon for mocking it.

The primary result of this change is to allow for publishing to Github Enterprise instances.

bchr02 commented 6 years ago

@allenluce Thank you!

allenluce commented 6 years ago

No problem! Thanks for touching up the tests afterwards.