search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

Sinon is a dependency - shouldn't it be a dev dependency #25

Closed neophob closed 6 years ago

neophob commented 6 years ago

Hi

I just checked for large node_modules and saw that this package include sinon as dependency instead of a devdependency.

there's also only one require in a test. i'll do a PR

bchr02 commented 6 years ago

closed by https://github.com/bchr02/node-pre-gyp-github/pull/26. Thank you!