search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

HttpError "Not found" #33

Closed cisaacson closed 2 years ago

cisaacson commented 4 years ago

I am getting this error using node-pre-gyp-github version 1.4.3:

(node:23711) UnhandledPromiseRejectionWarning: HttpError: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/releases/#list-releases-for-a-repository"}
    at response.text.then.message (/Users/coryisaacson/git/rtip-rs/flatbuffer-idl-parser-js/node_modules/node-pre-gyp-github/node_modules/@octokit/rest/lib/request/request.js:72:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I saw this was an issue with an earlier release but I'm getting it now with this one. I am installed @octokit/rest": "^16.35.2 to ensure I have the latest.

Any recommendations appreciated. I have a valid github token and the repo is definitely valid too.

cisaacson commented 4 years ago

I changed the token rights to full repo access and it worked. Would be good to update the documentation. If someone can confirm the required token rights I am happy to provide a pull request for the doc.

Richienb commented 3 years ago

In order for the script to access a public repository to update the assets, you need to select the public_repo scope.

daniellockyer commented 2 years ago

Closing this as the documentation lists the public_repo scope 🙂