search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

Refactor #35

Open Richienb opened 4 years ago

Richienb commented 4 years ago

In this PR, I refactored the codebase in Typescript. The last thing to migrate is the tests.

If you want some help maintaining this repo, feel free to add me as a maintainer on GitHub and npm.

// @bchr02

Fixes: #32, Fixes: #33

bchr02 commented 4 years ago

Hi @Richienb. Yes, I would love your assistance to maintain this repo. I just added you as a contributor. Thank you!

bchr02 commented 4 years ago

In this PR, I refactored the codebase in Typescript. The last thing to migrate is the tests.

If you want some help maintaining this repo, feel free to add me as a maintainer on GitHub and npm.

// @bchr02

Fixes: #32, Fixes: #33

@Richienb did you see my last message? I went ahead and added you to this repo as a maintainer. I tried looking you up on npm so I could do the same there but I couldn't find you. What your npm username? Thanks.

Richienb commented 4 years ago

@bchr02 It's richienb. I'll finish up the pr when exams are done.

bchr02 commented 3 years ago

Hi @Richienb any update? By the way, I just added you on npm. thank you.

Richienb commented 3 years ago

@bchr02 The rewrite is complete. I just need to figure out how to stub modules for testing.