package-lock.json is listed in .gitignore

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.

MIT License

52 stars 32 forks source link

package-lock.json is listed in .gitignore #36

Closed justinkambic closed 2 years ago

justinkambic commented 3 years ago

Why do we have package-lock.json ignored?

This file is meant to be committed to the repo's version control, should we not remove that entry?

justinkambic commented 3 years ago

I created a PR that removes that entry from .gitignore and bumps the version of two packages that were out of date and causing npm to provide high/critical vulnerability warnings. https://github.com/bchr02/node-pre-gyp-github/pull/37

daniellockyer commented 2 years ago

Hey @justinkambic, I've just fixed this issue 🙂 I'll push dependency bumps soon