search

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.
MIT License
52 stars 32 forks source link

Update Default branch name #38

Open ultamatt opened 3 years ago

ultamatt commented 3 years ago

https://github.com/bchr02/node-pre-gyp-github/blob/5a993944952f40e414dab98cbadca12734c2d92a/index.js#L66

Hey! Thanks for this code. I'm working on using it along with the neon publish tutorial. It's not really working for me because of this default branch name stuff here. I can make a PR for this in a bit, but it would be nice if:

  1. We change this from 'master' to 'main'
  2. Perhaps later we could offer this field to be overloaded by the 'binary' in package.json.

Thanks! I'll maybe PR this if I can later tonight.

daniellockyer commented 2 years ago

Would love to see a PR 🙂

ultamatt commented 2 years ago

https://github.com/bchr02/node-pre-gyp-github/pull/44