Line endings broken again

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.

MIT License

52 stars 32 forks source link

Line endings broken again #4

Closed jacobrosenthal closed 8 years ago

jacobrosenthal commented 8 years ago

At some point accepting my PR line endings got broken again.

It seems one solution is .gitattributes file to force LF line endings: https://help.github.com/articles/dealing-with-line-endings/#per-repository-settings

Other ideas?

bchr02 commented 8 years ago

@jacobrosenthal Thanks for the link, it help me to figure it out. Apparently setting my text editor to use LF instead of CRLF was not enough because Git on windows automatically converts LF to CRLF. The solution was for me to turn this feature off like this: git config --global core.autocrlf false

Any chance I can get you to test it now? Thank you!

jacobrosenthal commented 8 years ago

Seems good again

bchr02 commented 8 years ago

Thanks @jacobrosenthal