fix overriding options - Githubissues

bchr02 / node-pre-gyp-github

A node-pre-gyp module which provides the ability to publish to GitHub releases.

MIT License

52 stars 32 forks source link

Closed jacobrosenthal closed 8 years ago

jacobrosenthal commented 8 years ago

Since draft is false, it previously never overrode the default. Check instead for key existence.

bchr02 commented 8 years ago

Sorry, I don't understand what you mean or under what scenario there would be an issue. Can you explain some more or provide a test case?

jacobrosenthal commented 8 years ago

> var blah = false || undefined
undefined
> console.log(blah)
undefined
undefined

bchr02 commented 8 years ago

Good catch. Okay, I will merge.

bchr02 commented 8 years ago

This is probably why I should create some unit tests. :-)

jacobrosenthal commented 8 years ago

I can now confirm --release works :)

bchr02 commented 8 years ago

Awesome thank you. Good work!