search

bchurchill / badi-cal

A javascript library for Badi calendar conversions.
https://bchurchill.github.io/badi-cal/
MIT License
11 stars 4 forks source link

.jshintignore, .jshintrc #22

Open bchurchill opened 7 years ago

bchurchill commented 7 years ago

After running npm run clean-build and npm run create-build there were two new files created, .jshintignore and .jshintrc. I don't know the best practice for handling these files in version control (or what they do, frankly), so perhaps we can decide if they should be added to the .gitignore or committed into the repository?

bchurchill commented 7 years ago

@brenmcnamara I intended to assign this to you but it doesn't look like you're a collaborator yet. To make that happen check this link: https://github.com/bchurchill/badi-cal/invitations.

brettz9 commented 7 years ago

.jshintrc includes the instructions on how to Run the Commands (RC) of JSHint, a linting project which I think has fallen out of favor a bit with the predominance now of ESLint. .jshintignore should indicate the files or directories that should be exempt from JSHint linting (e.g., node_modules).

Since you're already using ESLint, I don't think you actually want those files created, and from a quick glance at your code, I don't see how they were created as it seems it should be making ESLint files instead.

brettz9 commented 7 years ago

Btw, feel free to start a wiki page on @bahaidev listing Baha'i-related repos such as this one (if not the repo itself).

brettz9 commented 7 years ago

Btw, +9 for your project's use of ES6/Babel!

bchurchill commented 7 years ago

You can thank @brenmcnamara for that! I'm a foreigner in these vast and spacious lands of javascript...

brenmcnamara commented 7 years ago

Sorry for responding so late. I'm not sure how they got created but you don't want those files. We are using ESLint. These files are for configuring rules that check for javascript code quality. I can try to see why these files were created.

This isn't a breaking issue though. Whether you commit those files or not, things should work fine.

brenmcnamara commented 7 years ago

@brettz9 - It doesn't look like the Baha'i Dev organization has any owners. How can we add or get access to repos? Thanks!

brettz9 commented 7 years ago

When logging on recently, Github suggested renaming the "Owners" team since that team is no longer used to determine ownership (that is instead now handled by "roles").

I did just now add a "Collaborators" team as a general umbrella group, however, and added my TextBrowser repo to it (though if our numbers start getting unwieldy (a welcome development!), I might change to have teams for each repository along with any teams that combine repository access for related projects or teams for long-time contributing team members).

For future reference, as long is one is already a member of the organization (in this case, bahaidev), one can ask to join any (non-"secret") team in the organization.

But in this case, I've already added you both as members to that umbrella team (though in your case, @brenmcnamara , you'll first need to agree to join the organization, but after that, you should already have access to the group, and thus to TextBrowser (and any other repos you might wish to add for that team)).