bcit-ci / CodeIgniter

Open Source PHP Framework (originally from EllisLab)
https://codeigniter.com/
MIT License
18.27k stars 7.6k forks source link

Fix compatibility for PHP 8☠ #6260

Closed NathanMontois closed 9 months ago

tenzap commented 10 months ago

AFAIK ci3 must remain compatible with php 5.6 (maybe 5.4?)

pocketarc commented 10 months ago

@tenzap Good call. Adding symfony/polyfill could be an option; it'd handle this and enable the use of more recent PHP functions in other parts of the system.

Edit: Alternatively, spl_object_hash() is PHP 5.2+, and would probably be the best option.

gxgpet commented 9 months ago

Hi there.

If you could check the fix provided in #6264, it would be much appreciated. If you find anything faulty, please leave a comment there.