bcko / flutter_qrcode_reader

Flutter qrcode reader
MIT License
233 stars 92 forks source link

Changed reference to FlutterActivity to just Activity #63

Closed lfwells closed 4 years ago

lfwells commented 4 years ago

Some plugins (e.g. local_auth) require the user to change their MainActivity from a FlutterActivity to a FlutterFragmentActivity.

Guidlines on the Flutter plugin documentation suggest

Plugin authors should not assume the type returned by this method is any specific subclass of Activity (such as FlutterActivity or FlutterFragmentActivity), as applications are free to use any activity subclass.

I see no reason why the application needs a FlutterActivity specifically, and so I have change this to expect just a regular Activity. I have tested this in my own application that uses a FlutterFragmentActivity for local_auth, and have seen no problems.