search

bclinkinbeard / angular

AngularJS compiled with jsdom and provided as a CommonJS module. Intended for testing AngularJS code without depending on a browser.
MIT License
54 stars 22 forks source link

index-browserify.js is missing in source map #16

Closed binarykitchen closed 10 years ago

binarykitchen commented 10 years ago 
Error loading source:
Could not load the source for https://localhost:8080/home/michael.heuberger/binarykitchen/code/videomail.io/node_modules/angular/index-browserify.js.
Error: "https://localhost:8080/home/michael.heuberger/binarykitchen/code/videomail.io/node_modules/angular/index-browserify.js" is not in the SourceMap.
Stack: SourceMapConsumer_sourceContentFor@resource://gre/modules/devtools/SourceMap.jsm:391
SourceActor.prototype._getSourceText@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js:2452
resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:153
SourceActor.prototype.onSource@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js:2471
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1023
LDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258
makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:80
Line: 391, column: 6

I am seeing this in the Firefox console after bundling with browserify with the debug parameter.

relvao commented 10 years ago

Hi,

Using the non minified version would solve this. @bclinkinbeard do you see any disadvantage in changing index-browserify so it uses ./lib/angular instead of ./lib/angular.min?

Also, in the server side version (index.js), what is the advantage of having minified code? It makes debugging more dificult...

bclinkinbeard commented 10 years ago

I went ahead and made this change with the 1.2.19 release, published just now. You will now get the uncompressed version by default, and can use require('angular/min') to get the minified version.