search

bclinkinbeard / angular

AngularJS compiled with jsdom and provided as a CommonJS module. Intended for testing AngularJS code without depending on a browser.
MIT License
54 stars 22 forks source link

resolves #23: upgrade jsdom #29

Open boneskull opened 9 years ago

boneskull commented 9 years ago

This gets my tests passing under NodeJS v.0.11.14.

Before:

/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/node_modules/jsdom/lib/jsdom/level1/core.js:553
      Array.prototype.splice.call(this._childNodes, refChildIndex, 0, newChild
                             ^
TypeError: Cannot set property length of [object Object] which has only a getter
    at DocumentFragment.core.Node.insertBefore (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/node_modules/jsdom/lib/jsdom/level1/core.js:553:30)
    at DocumentFragment.<anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/node_modules/jsdom/lib/jsdom/level2/events.js:332:20)
    at DocumentFragment.proto.(anonymous function) [as insertBefore] (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/node_modules/jsdom/lib/jsdom/utils.js:23:26)
    at DocumentFragment.core.Node.appendChild (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/node_modules/jsdom/lib/jsdom/level1/core.js:671:17)
    at jqLiteBuildFragment (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:2330:20)
    at jqLiteParseHTML (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:2364:10)
    at Object.JQLite (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:2383:26)
    at forEach.prepend (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:3000:15)
    at Object.JQLite.(anonymous function) [as prepend] (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:3112:17)
    at eval (eval at <anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:3), <anonymous>:21956:88)
    at module.exports (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/custom.js:14:43)
    at Object.<anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/angular/index.js:1:99)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Volumes/samara/projects/boneskull/angular-types/test/types.spec.js:2:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /Volumes/samara/projects/boneskull/angular-types/node_modules/grunt-mocha-cov/node_modules/mocha/lib/mocha.js:183:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Volumes/samara/projects/boneskull/angular-types/node_modules/grunt-mocha-cov/node_modules/mocha/lib/mocha.js:180:14)
    at Mocha.run (/Volumes/samara/projects/boneskull/angular-types/node_modules/grunt-mocha-cov/node_modules/mocha/lib/mocha.js:382:31)
    at Object.<anonymous> (/Volumes/samara/projects/boneskull/angular-types/node_modules/grunt-mocha-cov/node_modules/mocha/bin/_mocha:381:16)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:124:16)
    at node.js:842:3

After: green tests.