Minor refactoring - Githubissues

bcmpinc / StardewHack

A bunch of Stardew Valley mods that heavily rely on IL code modification.

GNU Lesser General Public License v3.0

20 stars 14 forks source link

Minor refactoring #28

Closed Pathoschild closed 4 years ago

Pathoschild commented 4 years ago

This pull request...

Updates the mod build package to support the upcoming SMAPI 3.0 and Stardew Valley 1.4.
Migrates Harmony references to the new <EnableHarmony> option, which always uses the same version as SMAPI.
Migrates to the new .csproj format.
Uses nameof where possible to simplify maintenance. (This way an incorrect name, e.g. due to a field being renamed in a game update, is immediately apparent as a compile error instead of a runtime error when the affected code runs.)

Let me know if you want me to change anything!

bcmpinc commented 4 years ago

The changes in StardewHack2.sln are causing issues on my side. Monodevelop complains about an invalid configuration mapping. Reverting to the old version of that file fixes that.

Another issue is that I seem unable to download NuGet package Pathoschild.Stardew.ModBuildConfig Version 3.0.0-beta.8.

Pathoschild commented 4 years ago

I fixed the 'invalid configuration mapping' errors; those were because of a MonoDevelop bug with x86 build configuration.

You might need to tick "show pre-release packages" in the Add Packages dialogue to see the package:

If that doesn't fix it, do you get an error when you try to restore the NuGet package? Which version of MonoDevelop do you have? (It works for me in MonoDevelop 7.7 on Linux.)

bcmpinc commented 4 years ago

Somehow I missed that checkbox, though that wasn't the issue. Turns out that monodevelop has /usr/bin/mono64 hard coded as path, but that file doesn't exist on my system. Running ln -s /usr/bin/mono /usr/bin/mono64 fixed it though.