search

bcmpinc / StardewHack

A bunch of Stardew Valley mods that heavily rely on IL code modification.
GNU Lesser General Public License v3.0
20 stars 14 forks source link

[WearMoreRings,BiggerBackpacks,AlwaysScrollMap] Patch failed to apply cleanly for 1.5.5 #75

Closed justastranger closed 2 years ago

justastranger commented 2 years ago

Log can be found here

There are 6 of your mods in the log, 3 of which I've found beta updates for so far.

rodrigovda commented 2 years ago

This happened to me too, in my case the StardewHack mod I'm trying to use is Harvest With Scythe.

Log can be found here

EDIT: Sorry, wrong link, I updated it to the correct one

justastranger commented 2 years ago

This happened to me too, in my case the StardewHack mod I'm trying to use is Harvest With Scythe.

Log can be found here

You appear to have used the link to my log instead of yours.

justastranger commented 2 years ago

Here's a new log using the released betas for Harvest With Scythe, Tilled Soil Decay, and Grass Growth. Harvest With Scythe and Grass Growth still fail to apply patches.

rodrigovda commented 2 years ago

Ok I found the issue, with 1.5.5 you have to install the BETA version of the mod (I was using only harvest with scythe, Idk if any other mod must be updated): Harvest With Scythe-2731-5-3-beta-0-1631128844.zip

bcmpinc commented 2 years ago

I uploaded a new build with version number 5.5. These are effectively the same as the beta versions, but don't have a beta version number.

justastranger commented 2 years ago

Even with these new builds I'm counting 20 StardewHack.InstructionNotFoundExceptions across 5 StardewHack mods (half being from Wear More Rings).

StardewModdingAPI_2021-12-05_09-20-17

Log here

bcmpinc commented 2 years ago

@justastranger : please try again with the other failing mods removed. I cannot reproduce the errors and I want to be certain that your issues are not caused by any of the other failing mods.

justastranger commented 2 years ago

Updating to the latest hot patch for 1.5.5 and release of SMAPI caused the errors to disappear, though there are still 3 failed patches for WearMoreRings logged as trace. Log here. I'm a little boggled by this since they came out after your updates to 1.5.5 and just removing the other erroring mods didn't change anything.

justastranger commented 2 years ago

@justastranger I assume you're on GOG? There was an issue with the GOG / Game Pass build which changed how some method instructions would be compiled, which in turn would break mods which depend on transpilers.

bcmpinc commented 2 years ago

The Trace logs are intentional. Some patches have multiple versions and it just tries them until one works, but if none of them work I still need all the error messages to see what goes wrong. So they're printed as trace.