search

bcn49 / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Open items in background not working for highlighted articles #278

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the problem? Describe completely:
Receiving the above error in runtime-minimalist.js line 43  when the option to 
use [v] to open new tabs in background.

Minimalist version   - 0.6.3
Relevant core module - Reader
Chrome version       - Version 24.0.1312.56 m
Operating System     - Win 7
Language             - English
Google Apps user?    - No
Other extensions     - All other extensions disabled

Please provide any additional information below and attach screenshots if
relevant.

Original issue reported on code.google.com by garysto...@gmail.com on 25 Jan 2013 at 2:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for including the error! There might be a difference in custom event 
creation on Chrome 24. I need a closer look at the event object.

Please run the following code from the console:

    document.addEventListener('openTab', function() {
        console.log(JSON.stringify(event));
    });

Then try to open a tab in the background and paste the result here.

Original comment by anst...@gmail.com on 25 Jan 2013 at 9:03

GoogleCodeExporter commented 9 years ago 
Issue 279 has been merged into this issue.

Original comment by anst...@gmail.com on 25 Jan 2013 at 9:04

GoogleCodeExporter commented 9 years ago 
After executing the code above, I now receive this error:
Uncaught TypeError: Converting circular structure to JSON

Original comment by garysto...@gmail.com on 25 Jan 2013 at 9:06

GoogleCodeExporter commented 9 years ago 
I am not familiar with the code but do you need to send the event to the code?
document.addEventListener('openTab', function(event) {
        console.log(JSON.stringify(event));
    });

Original comment by garysto...@gmail.com on 25 Jan 2013 at 9:08

GoogleCodeExporter commented 9 years ago 
lol, apparently the events are just insane. Try it without the JSON stringify 
step:

    document.addEventListener('openTab', function() {
        console.log(event);
    });

Original comment by anst...@gmail.com on 25 Jan 2013 at 9:19

GoogleCodeExporter commented 9 years ago 
It is returning the Event.... see screenshot.

Original comment by garysto...@gmail.com on 25 Jan 2013 at 9:30

Attachments:

GoogleCodeExporter commented 9 years ago 
Hmm that looks like how version 0.5.20 and earlier. Please try restarting your 
browser and trying again.

Original comment by anst...@gmail.com on 25 Jan 2013 at 9:58

GoogleCodeExporter commented 9 years ago 
Same....

Original comment by garysto...@gmail.com on 25 Jan 2013 at 10:13

Attachments:

GoogleCodeExporter commented 9 years ago 
Can you give me a full data export? Please attach it as a text file.

Original comment by anst...@gmail.com on 25 Jan 2013 at 10:21

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I have found more info on this - if you open the item in the reading list by 
clicking on it or using the 'o' key, THEN hit the 'v' key it will open the item 
in the background in a new tab.  Prior to the most recent update, you did not 
need to open the item first to use the 'v' shortcut, you could simply highlight 
it in the reading list and hit 'v', then hit 'm' to mark as read.

Original comment by jcfor...@gmail.com on 26 Jan 2013 at 12:10

GoogleCodeExporter commented 9 years ago 
This is happening if you are using "Minimalist for Google Reader" instead of 
the new "Google Reader". The legacy module will be deleted automatically in 
0.6.6.

Original comment by anst...@gmail.com on 4 Feb 2013 at 2:29

GoogleCodeExporter commented 9 years ago 
Sorry, but I don't agree that this is only happening with the old module.  I 
deleted all modules and then did "Install Core Modules" and that did not fix 
it.  I even went so far as to completely uninstall Minimalist plugin and 
reinstall from scratch, verify that only the "new" modules (Gmail and Google 
Reader) were installed, and still the issue persists.

Maybe there is some remnants of the old module that remain even after deleting 
those modules and uninstalling the plugin?  If so please advise.

BTW I'm on Chrome 24.0.1312.57 for Mac, happens on two Macs - one is Snow 
Leopard and one is Mountain Lion.

Original comment by jcfor...@gmail.com on 4 Feb 2013 at 3:52

GoogleCodeExporter commented 9 years ago 
@jcforbes, do you get the same JS errors as @garystorey?

What do you mean by highlighting a story in the reading list vs opening it? I 
believe you are having a different issue than @garystorey (his is definitely an 
old module.)

Original comment by anst...@gmail.com on 4 Feb 2013 at 4:10

GoogleCodeExporter commented 9 years ago 
No, maybe it is a different issue.  I'm getting a different error after all.  
When you are in Google Reader, you can navigate through the feed using the 'n' 
and 'p' keys (next/previous) to move the highlighted line up and down the list 
(it's your "selected" collapsed article).  Anyway, you can then hit 'o' to Open 
(expand) that article in Google Reader and view the contents.  At that point 
you can hit 'v' to open it a background tab.  However, prior the update, the 
article did not have to be Open (using 'o' key) first, you could simply hit 'v' 
on the highlighted (collapsed) article and it would open in a background tab.

This made it quick to navigate through a feed and pop open all the ones you 
want to read in the background and then just mark all read to clear the rest 
out.

Here's the error contents when I hit 'v' on a highlighted article that is not 
open inside Google Reader:

Uncaught TypeError: Cannot call method 'getAttribute' of undefined (program):15
_min.(anonymous function).open.check

Attached is a screen cap.  Thanks!

Original comment by jcfor...@gmail.com on 4 Feb 2013 at 4:24

Attachments:

GoogleCodeExporter commented 9 years ago 
Ah! That is indeed a different issue. I did not know about [ N ] and [ P ], I 
always open every article (and just advance with [ J ] and [ K ]). There is a 
better selector I can use which will work in both cases. I will put that in the 
next update.

In the mean time, you can fix this manually by going to:
    Dashboard > Google Reader > Edit > General > Keyboard Shortcuts > Open items in back...
and replacing `.entry-title-link` on line 13 with `.entry-original`.

Let me know if that works!

Original comment by anst...@gmail.com on 4 Feb 2013 at 4:33

GoogleCodeExporter commented 9 years ago 
That did it!  Brilliant.  Thanks so much.  Really great piece of software.

Original comment by jcfor...@gmail.com on 4 Feb 2013 at 4:37

GoogleCodeExporter commented 9 years ago 
Excellent. I'm actually going to push this in an update in a few minutes 
because there is a critical migration bug that I have to hotfix. Thanks for 
your help debugging!

Original comment by anst...@gmail.com on 4 Feb 2013 at 4:41

GoogleCodeExporter commented 9 years ago 
Should update selector to `.entry-title-link, .entry-original` to support all 
views

Original comment by anst...@gmail.com on 4 Feb 2013 at 4:34

GoogleCodeExporter commented 9 years ago 
I still have this issue - I can reproduce when in Expanded View but it works in 
List View

Original comment by paul.fre...@gmail.com on 5 Feb 2013 at 9:01

GoogleCodeExporter commented 9 years ago 
Same with me as with Paul above - v will open the highlighted item in the 
background in list view, but in Expanded the key does nothing.

Original comment by jko...@gmail.com on 5 Feb 2013 at 2:36

GoogleCodeExporter commented 9 years ago 
Yes, this is a known issue. It can be fixed by going to:
  Dashboard > Google Reader > Edit > General > Keyboard Shortcuts > Open items in back...
and replacing `.entry-original` on line 13 with `.entry-original, 
.entry-title-link`

This will be included in the next update.

Original comment by anst...@gmail.com on 5 Feb 2013 at 4:08

GoogleCodeExporter commented 9 years ago 
That works. Thanks.  I realise now that is what you meant by the update in #19

Original comment by paul.fre...@gmail.com on 5 Feb 2013 at 4:13

GoogleCodeExporter commented 9 years ago 
No worries, #19 was confusing and out of context, that was just a note for 
myself :-)

Original comment by anst...@gmail.com on 5 Feb 2013 at 4:14