bcndev / bytecoin

GNU Lesser General Public License v3.0
230 stars 221 forks source link

walletd: --wallet-password-file? #98

Open KrzysztofHajdamowicz opened 5 years ago

KrzysztofHajdamowicz commented 5 years ago

I'm running a production instance of bytecoin. walletd requires to enter a password via stdin. There's deprecated method to enter it via argv param.

Maybe there should be an option to specify a file with a password, so I can store passwd here and chmod 600 that file, so nobody else can touch it?

ConnorBP commented 5 years ago

I agree. I have been running into a similar problem. I'm likely going to make the modification my self very soon. I may set up an option to get the variable from the environment as well.

ConnorBP commented 5 years ago

feel free to use the code from this commit in my fork i just added ;) https://github.com/cryptogems-currency/cryptogem/commit/90d1ca3b10feddbdf550a48f666e28997eb8fc9d I have not tested the file one but it should work. The environment variables work perfectly however.

bcndev commented 5 years ago

@KrzysztofHajdamowicz Please have a look at the subsection in our wiki where we give a recipe for doing this right.

KrzysztofHajdamowicz commented 5 years ago

@KrzysztofHajdamowicz Please have a look at the subsection in our wiki where we give a recipe for doing this right.

This isn't a solution for doing this right via systemd.