bcnmy / biconomy-client-sdk

Biconomy SDK is a plug & play toolkit for dApps to build transaction legos that enable a highly customised one-click experience for their users
MIT License
73 stars 76 forks source link

feat: transfer ownership #484

Closed VGabriel45 closed 4 months ago

VGabriel45 commented 4 months ago

Added transferOwnership() method in BiconomySmartAccountV2.

When transferring ownership of a smart account using this method, it is important to specify the accountAddress parameter when logging in with the new owner. Failing to do so would result in the SDK utilizing the counterfactual address contract instead of the intended account address.

const _smartAccount = await createSmartAccountClient({ signer: walletClient, paymasterUrl, bundlerUrl, accountAddress: "0x...", })


PR-Codex overview

This PR introduces a new method transferOwnership to transfer ownership of a smart account. It also adds ECDSAModule ABI and related tests.

Detailed summary

The following files were skipped due to too many changes: tests/modules/write.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size
core (esm) 52.36 KB (+0.21% 🔺)
core (cjs) 56.95 KB (+0.14% 🔺)
account (tree-shaking) 51.32 KB (+0.03% 🔺)
bundler (tree-shaking) 2.33 KB (0%)
paymaster (tree-shaking) 2.27 KB (0%)
modules (tree-shaking) 40.05 KB (0%)
livingrockrises commented 4 months ago

does the test cover connecting with new eoa once transfer ownership is mined?

VGabriel45 commented 4 months ago

does the test cover connecting with new eoa once transfer ownership is mined?

Yes

joepegler commented 4 months ago

Nice job